Skip to content

PYTHON-5788 - Refine withTransaction timeout error wrapping semantics…#2745

Merged
NoahStapp merged 1 commit intomongodb:backpressurefrom
NoahStapp:PYTHON-5788
Apr 13, 2026
Merged

PYTHON-5788 - Refine withTransaction timeout error wrapping semantics…#2745
NoahStapp merged 1 commit intomongodb:backpressurefrom
NoahStapp:PYTHON-5788

Conversation

@NoahStapp
Copy link
Copy Markdown
Contributor

@NoahStapp NoahStapp commented Apr 7, 2026 •
edited
Loading

… and label propagation in spec and prose tests

PYTHON-5788

Changes in this PR

  • Only wrap retryable errors thrown during withTransaction calls with _make_timeout_error.
  • Update prose tests to assert that the labels of propagated timeout errors match the error labels of the wrapped error.

Test Plan

Updated existing prose tests.

Checklist

Checklist for Author

  • Did you update the changelog (if necessary)?
  • Is there test coverage?
  • Is any followup work tracked in a JIRA ticket? If so, add link(s).

Checklist for Reviewer

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Is all relevant documentation (README or docstring) updated?

@NoahStapp
PYTHON-5788 - Refine withTransaction timeout error wrapping semantics…
6be95c7 
… and label propagation in spec and prose tests
@NoahStapp NoahStapp requested a review from a team as a code owner April 7, 2026 18:46
@NoahStapp NoahStapp requested review from caseyclements and removed request for a team April 7, 2026 18:46
@NoahStapp NoahStapp mentioned this pull request Apr 7, 2026
Merged
4 tasks
aclark4life
aclark4life approved these changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@aclark4life aclark4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NoahStapp NoahStapp merged commit d864822 into mongodb:backpressure Apr 13, 2026
83 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aclark4life aclark4life aclark4life approved these changes

@sleepyStick sleepyStick sleepyStick approved these changes

@caseyclements caseyclements Awaiting requested review from caseyclements caseyclements is a code owner automatically assigned from mongodb/dbx-python

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NoahStapp @aclark4life @sleepyStick